-
Notifications
You must be signed in to change notification settings - Fork 93
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create TruncatedNormalHyperparameter #302
Comments
The initial reaction was to have a heirarchy of x = NormalFloatHyperparameter(...)
y = TruncatedNormalFloatHyperparameter(...)
items = [x, y, ...] # Some other hyperparameter types
for item in items:
if isinstance(item, NormalFloatHyperparameter):
... # This would match both x and y The correct solution would then be: if isinstance(item, NormalFloatHyperparameter) and not isinstance(item, TruncatedNormalFloatHyperparameter):
... # This is the only way to match just x I'm okay with some minor code duplication to keep these seperated, otherwise we need some This would also constitute a pretty major breaking change and a version bump. This should probably be done at the same time as doing so for |
We'll no longer have unbounded hyperparameters in #346 so that all hyperparameters are have explicit bounds. |
To decouple the code for bounded and unbounded normal hyperparameters.
The text was updated successfully, but these errors were encountered: