-
Notifications
You must be signed in to change notification settings - Fork 93
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Bug] UniformFloatHyperparameter Typing check bug #342
Comments
Hiyo, sorry for not replying. This was a cythonization issue but #346 removed Cython entirely. Hopefully this gets released next week :) |
Hi, I encountered the same problem described here and wanted to ask if it has been fixed. |
Hi @JusciAvelino, not yet. Almost finished with the PR at #346. Just documentation setup left |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
I noticed there was a bug in the typing check when I tried to install it in a ppc64le architecture supercomputer. The ConfigSpace version I am using is
0.7.2
. When running the following example code,An error will be given:
I tried to reproduce it on my personal laptop with x86/x64 architecture, but it didn't show up. After a deep dive into the code, I found that line 62 in
uniform_float.pyx
is a default value checking:self.default_value = self.check_default(default_value)
. At line 14, we can see that the default value could be both integer or float value:default_value: Union[int, float, None] = None
. But the type checking functiondef check_default(self, default_value: Optional[float]) -> float:
only allow float value parameter.I eventually fixed this by changing the definition to
def check_default(self, default_value: Optional[Union[int, float]]) -> float:
. I think there might be similar issues in the other place in the codebase.The text was updated successfully, but these errors were encountered: