Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check that a condition is only part of one ConfigurationSpace object #72

Closed
mfeurer opened this issue Feb 27, 2018 · 3 comments
Closed

Comments

@mfeurer
Copy link
Contributor

mfeurer commented Feb 27, 2018

by generating a random number for the configuration space on instantiation. When a condition is added, the configuration space will save it in the condition object, and error if there already is a different random number. Thereby, the bug of having a condition in two configuration spaces is effectively prevented.

@eddiebergman
Copy link
Contributor

What's the issue of having them in two different spaces?

@eddiebergman
Copy link
Contributor

This could also potentially be an issue if the hyperparameters are shared between two configuration spaces, but the hyperparameters have different vector indices.

Since the condition is the only thing shared, the information that it was added to a space needs to somehow live on that condition. Potential solutions:

  • set_vector_idx also takes in some identifier, some combination of the spaces name and seeding. Not sure what issues this would cause though.
  • Ignore it, consider it user error and document this

@eddiebergman
Copy link
Contributor

I would consider this a user error honestly and make sure to document this clearly when dealing with conditionals, it's much simpler and defensive checking into non-usual behaviours is an endless battle for Python.

Feel free to re-open this if you feel otherwise @mfeurer

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants