-
Notifications
You must be signed in to change notification settings - Fork 93
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Check that a condition is only part of one ConfigurationSpace object #72
Comments
What's the issue of having them in two different spaces? |
This could also potentially be an issue if the hyperparameters are shared between two configuration spaces, but the hyperparameters have different vector indices. Since the condition is the only thing shared, the information that it was added to a space needs to somehow live on that condition. Potential solutions:
|
I would consider this a user error honestly and make sure to document this clearly when dealing with conditionals, it's much simpler and defensive checking into non-usual behaviours is an endless battle for Python. Feel free to re-open this if you feel otherwise @mfeurer |
by generating a random number for the configuration space on instantiation. When a condition is added, the configuration space will save it in the condition object, and error if there already is a different random number. Thereby, the bug of having a condition in two configuration spaces is effectively prevented.
The text was updated successfully, but these errors were encountered: