Use isinstance instead of obj.__bases__ in ThirdPartyComponents
#1686
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a small change but will enable much easier extending of auto-sklearn algorithms, since without this change, all classes are expected to directly inherit from AutoSklearn base calsses, and do not allow additional layers of inheritance.
|
@eddiebergman this API may be deprecated soon due to the upcoming major refactor, but I have tooling around existing auto-sklearn which this would definitely simplify. I'd appreciate your feedback. |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## development #1686 +/- ##
===============================================
- Coverage 83.45% 83.21% -0.25%
===============================================
Files 156 156
Lines 11934 11934
Branches 1900 1900
===============================================
- Hits 9960 9931 -29
- Misses 1409 1435 +26
- Partials 565 568 +3 |
|
Hi @AmirAlavi, Can you take a look at the failing tests? Seems some other changes need to be done as well. Best, |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a small change but will enable much easier extending of auto-sklearn algorithms, since without this change, all classes are expected to directly inherit from AutoSklearn base calsses, and do not allow additional layers of inheritance.
Closes #1604