Update tests for browser preferences refactor

Author: ArthurRodrigues4433

pydoll/browser/interfaces.py

@@ -1,5 +1,6 @@
 from abc import ABC, abstractmethod
 
+from pydoll.browser.preference_types import BrowserPreferences
 from pydoll.constants import PageLoadState
 
 
@@ -25,7 +26,7 @@ def add_argument(self, argument: str):
 
     @property
     @abstractmethod
-    def browser_preferences(self) -> dict:
+    def browser_preferences(self) -> BrowserPreferences:
         pass
 
     @property

pydoll/browser/options.py

@@ -1,5 +1,5 @@
 from contextlib import suppress
-from typing import Any, Optional
+from typing import Any, Dict, Optional, cast
 
 from pydoll.browser.interfaces import Options
 from pydoll.browser.preference_types import PREFERENCE_SCHEMA, BrowserPreferences
@@ -154,9 +154,11 @@ def _set_pref_path(self, path: list, value):
         self._validate_pref_path(path)
         self._validate_pref_value(path, value)
 
-        d = self._browser_preferences
+        d: Dict[str, Any] = cast(Dict[str, Any], self._browser_preferences)
         for key in path[:-1]:
-            d = d.setdefault(key, {})
+            if key not in d or not isinstance(d[key], dict):
+                d[key] = {}
+            d = cast(Dict[str, Any], d[key])
         d[path[-1]] = value
 
     @staticmethod
@@ -217,10 +219,10 @@ def _get_pref_path(self, path: list):
         except InvalidPreferencePath:
             raise
 
-        nested_preferences = self._browser_preferences
+        nested_preferences: Dict[str, Any] = cast(Dict[str, Any], self._browser_preferences)
         with suppress(KeyError, TypeError):
             for key in path:
-                nested_preferences = nested_preferences[key]
+                nested_preferences = cast(Dict[str, Any], nested_preferences[key])
             return nested_preferences
         return None
 

pydoll/browser/preference_types.py

@@ -1,4 +1,6 @@
-from typing import NotRequired, TypedDict
+from typing import TypedDict
+
+from typing_extensions import NotRequired
 
 
 class DownloadPreferences(TypedDict):

tests/test_browser/test_browser_preferences.py

@@ -153,4 +153,15 @@ def test_set_pref_path_creates_structure():
         }
     })
     options._set_pref_path(['profile', 'default_content_setting_values', 'popups'], 0)
-    assert cast(Any, options.browser_preferences)['profile']['default_content_setting_values']['popups'] == 0
+    assert cast(Any, options.browser_preferences)['profile']['default_content_setting_values']['popups'] == 0
+
+
+def test_validate_pref_value_dict_validation():
+    """Test validation when expected type is dict."""
+    options = ChromiumOptions()
+    # Test valid dict
+    options._validate_pref_value(['intl'], {'accept_languages': 'pt-BR'})
+
+    # Test invalid dict (should raise)
+    with pytest.raises(InvalidPreferenceValue):
+        options._validate_pref_value(['intl'], 'not_a_dict')

tests/test_managers/test_browser_managers.py

@@ -245,3 +245,14 @@ def test_initialize_options_preserves_custom_arguments():
     assert '--custom-flag' in result.arguments
     assert '--no-first-run' in result.arguments
     assert '--no-default-browser-check' in result.arguments
+
+
+def test_handle_cleanup_error_cache_file_retry_fails_raises(temp_manager):
+    """Test that non-cache files raise PermissionError when retry fails."""
+    func_mock = Mock()
+    temp_manager.retry_process_file = Mock(side_effect=PermissionError)
+
+    # Non-cache file should raise after retry fails
+    path = "/tmp/some_file.txt"
+    with pytest.raises(PermissionError):
+        temp_manager.handle_cleanup_error(func_mock, path, (PermissionError, PermissionError(), None))