feat: pipe stream on fs write #206
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matt-forster
reviewed
Aug 4, 2020
matt-forster
previously approved these changes
Aug 25, 2020
trs
reviewed
Aug 25, 2020
Replacing write data with pipe on STOR command Co-authored-by: Tyler Stewart <hello@tylerstewart.ca>
trs
suggested changes
Aug 25, 2020
matt-forster
approved these changes
Aug 25, 2020
|
🎉 This PR is included in version 4.4.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR aim is to make socket pipe method available on
FTPcommandSTOR, in order to support other methods and make it more versatile to support other npm packages likes3fs. because of an issue to write the stream directly toAWS S3, i decided to allow pipe method onSTORcommand. That may help you to come up with a better solution. also, there was a problem onsockt.resumefunction, which triggers error, if it does not exist probably because the socket is closed.Thanks