feat: npm updates, security zero, test corrections #296
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matt-forster
force-pushed
the
npm-updates
branch
from
ce8f2a1 to
c54c889
Compare
matt-forster
force-pushed
the
npm-updates
branch
from
37d57cb to
3a52fbe
Compare
matt-forster
force-pushed
the
npm-updates
branch
from
3a52fbe to
ee43174
Compare
matt-forster
changed the title
Xjph
reviewed
Apr 18, 2022
Comment on lines
144
to
161
| close() { | ||
| this.log.info('Server closing...'); | ||
| this.server.maxConnections = 0; | ||
| return Promise.map(Object.keys(this.connections), (id) => Promise.try(this.disconnectClient.bind(this, id))) | ||
| this.log.info('Closing connections:', Object.keys(this.connections).length); | ||
|
|
||
| return Promise.all(Object.keys(this.connections).map((id) => this.disconnectClient(id))) | ||
| .then(() => new Promise((resolve) => { | ||
| this.server.close((err) => { | ||
| this.log.info('Server closing...'); | ||
| if (err) this.log.error(err, 'Error closing server'); | ||
| resolve('Closed'); | ||
| }); | ||
| })) | ||
| .then(() => this.removeAllListeners()); | ||
| .then(() => { | ||
| this.log.debug('Removing event listeners...') | ||
| this.removeAllListeners(); | ||
| return; | ||
| }); | ||
| } |
There was a problem hiding this comment.
Definitely like this extra detail in the logging.
|
🎉 This PR is included in version 4.6.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BREAKING CHANGE: drop support for node v10 (out of LTS)