Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix #336, Added errors to typescript declarations #337

Merged
merged 1 commit into from
Oct 3, 2023
Merged

Fix #336, Added errors to typescript declarations #337

merged 1 commit into from
Oct 3, 2023

Conversation

paulober
Copy link
Contributor

Acceptance Checklist

  • Story: Code is focused on the linked stories and solves a problem (Add Errors into typescript declarations #336)
  • One of:
    • For Bugs: A unit test is added or an existing one modified
    • For Features: New unit tests are added covering the new functions or modifications
  • Code Documentation changes are included for public interfaces and important / complex additions
  • External Documentation is included for API changes, or other external facing interfaces

Review Checklist

  • The code does not duplicate existing functionality that exists elsewhere
  • The code has been linted and follows team practices and style guidelines
  • The changes in the PR are relevant to the title
    • changes not related should be moved to a different PR
  • All errors or error handling is actionable, and informs the viewer on how to correct it

See changes in #336.

@paulober paulober requested a review from a team as a code owner August 30, 2022 09:37
@paulober
Copy link
Contributor Author

paulober commented Jul 6, 2023

@botovance

iamart
iamart approved these changes Jul 6, 2023
View reviewed changes
Copy link

@iamart iamart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your contribution!

@some-git-user
Copy link

Could someone with write access merge this please?

@paulober paulober requested a review from iamart October 3, 2023 15:30
@iamart iamart merged commit e8efe32 into QuorumDMS:main Oct 3, 2023
@botovance
Copy link
Contributor

🎉 This PR is included in version 4.6.3 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iamart iamart Awaiting requested review from iamart

Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@paulober @some-git-user @botovance @iamart