Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor conditional ROS_DISTRO_GALACTIC include with __has_include #2235

Closed
3 tasks done
ralwing opened this issue Nov 7, 2022 · 1 comment
Closed
3 tasks done

Comments

@ralwing
Copy link
Contributor

ralwing commented Nov 7, 2022

Checklist

  • I've read the contribution guidelines.
  • I've searched other issues and no duplicate issues were found.
  • I've agreed with the maintainers that I can plan this task.

Description

Replace

#ifdef ROS_DISTRO_GALACTIC

with

#if __has_include

where applicable

Purpose

This will release code from environmentall variables and also make it more readable and easier to configure, and still galactic/humble compatible.

Possible approaches

Refactor code

Definition of done

All conditional includes replaced with suggested change.

@kenji-miyake
Copy link
Contributor

kenji-miyake commented Nov 7, 2022

Wrote my concerns here: #2236 (comment)

This will release code from environmentall variables and also make it more readable and easier to configure,

@ralwing Could you explain the reason why you felt so? I feel it's not clear.
Also, does environment variables cause any problem?

@ralwing ralwing closed this as completed Nov 8, 2022
@ralwing ralwing closed this as not planned Won't fix, can't repro, duplicate, stale Nov 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants