Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new lateral margin to obstacle_stop_planner to handle cut-in scenario in adaptive cruise control #2262

Closed
3 tasks done
VRichardJP opened this issue Nov 10, 2022 · 3 comments
Labels
component:planning Route planning, decision-making, and navigation. (auto-assigned) type:bug Software flaws or errors.

Comments

@VRichardJP
Copy link
Contributor

VRichardJP commented Nov 10, 2022

Checklist

  • I've read the contribution guidelines.
  • I've searched other issues and no duplicate issues were found.
  • I've agreed with the maintainers that I can plan this task.

Description

Currently, the lateral margin of the stop planner (or slow down planner if enabled) is used to define the detection range of the adaptive cruise control module.

Since the lateral margin of stop planner is meant to be quite small (0.0 by default), the ACC can't see what is going on outside our lane. As a consequence, the ego vehicle brakes strongly every single time a new vehicle cuts into our lane.

It seems that this problem could be solved by using a bigger margin for ACC (something like ~5 meters). In the current state, there is no choice but to increase the stop planner or slow down planner lateral margin, which of course would have some undesirable side effects.

However, I have tested the following trick:

  • enable slow down planner
  • set slow down planner lateral margin to 5.0
  • set slow down velocity to very high value, like 20m/s (so that there is no slow down)

With this settings, the ACC seems to adapt nicely to other vehicles, even when they first enter our lane. Of course, the consequence is that I cannot use the slow down planner as it is originally intended.

Purpose

For ACC to handle other vehicle changing lane.

Possible approaches

Add new lateral margin parameter to configure ACC obstacle detection range.

Definition of done

  • When another vehicle moves to our lane, the ACC kicks in immediately and no hard braking occurs (like for static obstacles)
@BonoloAWF BonoloAWF added the type:bug Software flaws or errors. label Nov 15, 2022
@xmfcx xmfcx added the component:planning Route planning, decision-making, and navigation. (auto-assigned) label Nov 15, 2022
@satoshi-ota
Copy link
Contributor

satoshi-ota commented Nov 29, 2022

Hi @VRichardJP Thanks for your idea 👍


For your information.

As you know, the current obstacle_stop_planner does not have rich features for cut-in scenarios.

On the other hand, we TIER IV working on developping new planner obstacle_cruise_planner that is richer than the old one and supports cut-in scenario. If you want to try it, you have to set the following parameter cruise_planner as obstacle_cruise_planner.

Note: the obstacle_cruise_planner based on not pointcloud but object recognition result. (docs)

add_launch_arg(
"cruise_planner", "obstacle_stop_planner", "cruise planner type"
) # select from "obstacle_stop_planner", "obstacle_cruise_planner", "none"

@xmfcx
Copy link
Contributor

xmfcx commented Dec 13, 2022

@VRichardJP would you like to try obstacle_cruise_planner or prefer to contribute to obstacle_stop_planner?

@VRichardJP
Copy link
Contributor Author

VRichardJP commented Dec 15, 2022

The current hack I have been using so far is good enough for me. So if everyone plans to use obstacle_cruise_planner in a near future I don't see the point into updating the obstacle_stop_planner. We can close this I guess?

@xmfcx xmfcx closed this as completed Jan 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:planning Route planning, decision-making, and navigation. (auto-assigned) type:bug Software flaws or errors.
Projects
None yet
Development

No branches or pull requests

4 participants