You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
It is currently a bit unpractical to supply a constant max_units because some programs called externally may use more than others, and if we offload this to the parameters of the function then it adds more complexity. It would be nice to be able to pass an option to the current max_units field of the ExternalCallContext and in the case of this value being None, any unit that has not been spent would be refunded to the current context.
The text was updated successfully, but these errors were encountered:
When using constants, it's clear that passing 0 to forward all gas makes sense because the current behaviour would be not being able to execute anything but there could be footguns if the gas is dynamic and it would be harder to reason about when all the gas is forwarded vs what is passed. Currently done with an enum #1417 which avoids this pitfall but the builder pattern looks better.
It is currently a bit unpractical to supply a constant
max_units
because some programs called externally may use more than others, and if we offload this to the parameters of the function then it adds more complexity. It would be nice to be able to pass an option to the currentmax_units
field of theExternalCallContext
and in the case of this value beingNone
, any unit that has not been spent would be refunded to the current context.The text was updated successfully, but these errors were encountered: