Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Warp backend database pruning #471

Closed
minghinmatthewlam opened this issue Jan 30, 2023 · 2 comments
Closed

Warp backend database pruning #471

minghinmatthewlam opened this issue Jan 30, 2023 · 2 comments
Assignees
Labels
enhancement New feature or request warp

Comments

@minghinmatthewlam
Copy link

The warp backend has a database that saves the UnsignedMessage upon AddMessage calls, mostly to address case when node gets restarted and changes its bls key. Follow up from warp backend is to have a periodic cleanup of database messages.

Solutions:

@minghinmatthewlam minghinmatthewlam added the enhancement New feature or request label Jan 30, 2023
@minghinmatthewlam minghinmatthewlam moved this from 📋 Backlog to 🔖 Ready in Avalanche Warp Messaging Jan 30, 2023
@minghinmatthewlam minghinmatthewlam self-assigned this Jan 30, 2023
@aaronbuchwald aaronbuchwald changed the title Warp backend database cleanup Warp backend database pruning Mar 21, 2023
@aaronbuchwald aaronbuchwald added this to EVM May 1, 2023
@aaronbuchwald aaronbuchwald moved this to Backlog 🗄 in EVM May 1, 2023
@morrisettathena
Copy link
Contributor

Hi all,

The current approach that Aaron and I took is to have a configurable cap on the maximum number of entries in the database. When the database has reached the cap, it will delete the oldest entry to make room for the new one. Therefore, there will be two logically separated databases keeping track of entries.

The current database, where messageID -> unsignedmessage
The new database, where, messageCount -> messageID.

This keeps the implementation simple. And, with a large enough cap, the only messages that would be flushed out are no longer relevant to the current state.

@aaronbuchwald aaronbuchwald moved this from Backlog 🗄 to In Progress 🏗 in EVM Jun 16, 2023
@aaronbuchwald
Copy link
Collaborator

Closed by #702

@github-project-automation github-project-automation bot moved this from 🔖 Ready to ✅ Done in Avalanche Warp Messaging Jul 24, 2023
@github-project-automation github-project-automation bot moved this from In Progress 🏗 to Done ✅ in EVM Jul 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request warp
Projects
No open projects
Archived in project
Archived in project
Development

No branches or pull requests

3 participants