Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move annotations back into io.dinject package (remove separate dinject-annotations module) #45

Closed
rbygrave opened this issue Jul 23, 2020 · 0 comments
Closed

Move annotations back into io.dinject package (remove separate dinject-annotations module) #45

rbygrave opened this issue Jul 23, 2020 · 0 comments
Assignees
@rbygrave
Milestone
dinject-2.2

Comments

@rbygrave
Copy link
Contributor

Dang, got regrets that I moved the annotations in order to make the build better but felt I did that for the wrong reasons. I could move the annotations back into dinject (which seems natural) as long as I move the integration tests which is what we have done for this 2.2 release.
@rbygrave rbygrave added this to the 2.2 milestone Jul 23, 2020
@rbygrave rbygrave self-assigned this Jul 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rbygrave rbygrave

Labels
None yet
Projects
None yet
Milestone
dinject-2.2
Development

No branches or pull requests
1 participant
@rbygrave