Skip to content

Commit 4a0ce8d

Browse files
authored
Merge pull request #439 from SentryMan/fix-cascade-warning
Only Log Cascade Warning when in the Same Module
1 parent 7d14acd commit 4a0ce8d

File tree

1 file changed

+9
-2
lines changed

1 file changed

+9
-2
lines changed

jsonb-generator/src/main/java/io/avaje/jsonb/generator/TypeReader.java

Lines changed: 9 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -358,8 +358,15 @@ private void matchFieldToSetter(FieldReader field) {
358358
field.setUseGetterAddAll();
359359
} else if (ProcessingContext.isCascadeType(baseType)) {
360360
nonAccessibleField = true;
361-
logWarn(field.element(), errorContext + baseType + ", non public field %s with no matching setter or constructor?", field.fieldName());
362-
361+
var module = APContext.getProjectModuleElement();
362+
if (!module.isUnnamed() && module.equals(APContext.elements().getModuleOf(baseType))) {
363+
logWarn(
364+
field.element(),
365+
"%s%s, non public field %s with no matching setter or constructor?",
366+
errorContext,
367+
baseType,
368+
field.fieldName());
369+
}
363370
} else {
364371
logError(field.element(), errorContext + baseType + ", non public field %s with no matching setter or constructor?", field.fieldName());
365372
}

0 commit comments

Comments
 (0)