Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make test-worker process independent #1576

Closed
unional opened this issue Nov 1, 2017 · 4 comments
Closed

Make test-worker process independent #1576

unional opened this issue Nov 1, 2017 · 4 comments

Comments

@unional
Copy link

unional commented Nov 1, 2017

ava@0.23

I am trying to work on a vscode extension to support debugging with AVA+TypeScript.

I looked at profile.js and IMO it hacks around to fool test-worker that it is working on a child process.

Would you take a PR to make test-worker communicates using events and the current consuming code have an adapter between the event emitter and the process?

@novemberborn
Copy link
Member

I don't think we're ready to settle on any kind of stable interface to the workers, or indeed making these low-level parts extensible, sorry. The best bet at this stage is to use the CLI. The profile.js stuff is quite the hack in itself and not fully baked IMHO.

(Closing now to keep the issue count down, but please feel free to continue the discussion.)

@sindresorhus
Copy link
Member

@unional Would #1332 help you? If so, that one is "PR welcome". If not, can you elaborate on what you need instead of how? Maybe we can figure out a better way to achieve it together :)

@unional
Copy link
Author

unional commented Nov 3, 2017

I think it might. My idea is to make the test-worker independent from the context thou. i.e. it should contain logic to run test, without knowing it is running in process or vm.
Then, you can consume it in process or vm by just using an adapter to hook up the events from an event emitter to the process or vm

@sindresorhus
Copy link
Member

sindresorhus commented Nov 3, 2017

@unional Agreed. That's how it should work. Feel free to explore this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants