Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add more clarification for different Babel config in .babelrc.md #1642

Merged
merged 3 commits into from
Jan 21, 2018
Merged

Add more clarification for different Babel config in .babelrc.md #1642

merged 3 commits into from
Jan 21, 2018

Conversation

willnode
Copy link
Contributor

Fixes #1640. Add more explanation for the difference between tests vs sources babel configuration.

We may need to update the france translation later.

Add more explanation for the difference between tests vs sources babel configuration.
@@ -36,6 +36,8 @@ You can override the default Babel configuration AVA uses for test transpilation
}
```

Note that this only overrides babel for transpiling tests. If you have sources linked to a test, then you still need to add separate babel configuration for sources explained [here](#transpiling-sources).
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

babel => Babel

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

@sindresorhus
Copy link
Member

Can you give the PR a proper title?

@willnode willnode changed the title Update babelrc.md Add more clarification for different Babel config in .babelrc.md Jan 20, 2018
babel -> Babel.
This is a revised PR from previous commit.
@willnode
Copy link
Contributor Author

All fixed. Sorry for that.

@novemberborn
Copy link
Member

@willnode I've pushed an edit, does it seem OK to you?

@willnode
Copy link
Contributor Author

@novemberborn looks better to me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Can't make custom Babel configuration specific for ava
3 participants