-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support arguments in "require" configuration #1666
Comments
Hey @novemberborn, I'd like to take on this task! |
@Jolo510 awesome, go for it! |
Hey, @novemberborn, I'd like to work on this task |
@amslv awesome, thanks! Since this issue was opened, we added support for We could do the stringifying and the parsing in the main process first, and then use our "deep equal" logic to make sure the values are the same: Line 282 in 6d12abf
|
@IssueHunt has funded $40.00 to this issue.
|
I don't understand your comment. are you proposing a way to solve this issue? if yes, can you explain in different way?
I did some research and it seems that i must create a temp-js-file that will contain the call to do you think my idea is ok? |
@stavalfi I'm not sure what your question is. Could you rephrase it? |
@novemberborn Is anyone working on this issue? Can I give it a try? |
@niteshsarode please do! |
@novemberborn I would like to give this a try if no-one's working on it |
@OMLAKSHMI yes, that'd be great, thanks. @niteshsarode please do let us know if you are about to submit a pull request 😄 |
Hi @novemberborn Thanks |
I would like to ask you about this comment. As in this Comment You stated about the main process One need to compare the JSON(arguments) and then use the deepEqual from assert.js (Correct me If I am wrong). As I am new to this repo Can You let me know where exactly the |
The main process is what loads the configuration. Essentially we can add a validation step before this return: Line 163 in b71f396
You wouldn't use |
Hi, @novemberborn Can I work on this issue? I would like to give it a try. Thanks |
@abhnvgupta thanks for letting us know @abhnvgupta, better luck next time! 😄 |
is it still possible to work on this? |
@thyrhone all yours. |
Hey @novemberborn , I assume this issue is free to take now? Could you tell me if there is anything special here - since there is a lot of people resign from doing this? |
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
@sculpt0r yep. No I don't think there's anything special about it. |
So @novemberborn - could you assign me to to this ticket? |
@sculpt0r just start the work, I doubt anybody will jump in before you. |
@novemberborn could you assign me to this ticket |
Can i try this task? |
This will land in #3184. |
Hi is this issue still open |
No, this will land in #3184. |
Prompted by #1665 and inspired by Babel's plugin / preset configuration, it'd be neat to do this:
If an array is provided we'd require the module, resolve any
__esModules
/default
shenanigans, and invoke.apply()
with the remaining values. We should support any number of arguments.IssueHunt Summary
sculpt0r has been rewarded.
Backers (Total: $40.00)
Submitted pull Requests
options.require
config propertyTips
The text was updated successfully, but these errors were encountered: