-
Notifications
You must be signed in to change notification settings - Fork 1.4k
Type definition tests #870
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Yes, I was thinking the same yesterday "we should have tests for the type definitions". That would definitely be an improvement to somewhat validate them as the definitions getting more complex and more features are added. |
When we add new API features we can use Except we don't test with AVA 😭 . |
@jamestalmage We can use skipped tests. |
Chiming in. Just shape test is not enough: |
It would almost certainly be better than the nothing we have now though! |
😄 of course. |
Oh, by the way, if you lobby on this... 😄 |
This seems to be related too: microsoft/TypeScript#9281 |
We also need this for a forthcoming Flow type definition: #1007 |
We have… something, now. Closing since it's not clear to me whether there are any deficiencies in our current approach. |
Uh oh!
There was an error while loading. Please reload this page.
It would be good to have a set of typescript fixtures that exercised the API.
The test would just be running the typescript compiler and ensuring it didn't complain about the syntax.
That seems to be how they do it for DefinitelyTyped.
@SamVerschueren @ivogabe - That sound like a good idea?
The text was updated successfully, but these errors were encountered: