Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support NODE_ICU_DATA in forked processes #962

Closed
jgkim opened this issue Jul 13, 2016 · 2 comments
Closed

Support NODE_ICU_DATA in forked processes #962

jgkim opened this issue Jul 13, 2016 · 2 comments
Labels
bug current functionality does not work as desired help wanted scope:test-environment

Comments

@jgkim
Copy link

jgkim commented Jul 13, 2016

With the almost same reason with #531, we need to ensure NODE_ICU_DATA is absolute in lib/fork.js.

Error Message & Stack Trace

#
# Fatal error in , line 0
# Failed to create ICU date format, are ICU data files missing?
#

==== C stack trace ===============================

 1: V8_Fatal
 2: v8::internal::(anonymous namespace)::CreateICUDateFormat(v8::internal::Isolate*, icu_57::Locale const&, v8::internal::Handle<v8::internal::JSObject>)
 3: v8::internal::Runtime_CreateDateTimeFormat(int, v8::internal::Object**, v8::internal::Isolate*)
 4: 0x1e1d30b0961b
 5: 0x1e1d30ced87c
@jgkim
Copy link
Author

jgkim commented Jul 19, 2016

It seems like this bug is also caused by #32.

@novemberborn
Copy link
Member

@jgkim #32 changes the CWD to always be that of the nearest package.json. However if you were to run AVA from a different directory, with a relative NODE_ICU_DATA path, the path in the child processes will still be wrong.

In other words we still need to make the path absolute.

@novemberborn novemberborn added bug current functionality does not work as desired help wanted labels Sep 23, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug current functionality does not work as desired help wanted scope:test-environment
Projects
None yet
Development

No branches or pull requests

2 participants