Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change Placement of Active Cue in Transcript Component #5609

Closed
2 tasks
joncameron opened this issue Jan 30, 2024 · 2 comments
Closed
2 tasks

Change Placement of Active Cue in Transcript Component #5609

joncameron opened this issue Jan 30, 2024 · 2 comments
Assignees

Comments

@joncameron
Copy link
Contributor

joncameron commented Jan 30, 2024

Description

Now that the height of the Details/Transcript tabs expands down to the bottom of the structured navigation, a good portion of the transcript text itself may be off-screen. In order to make sure that users can see the video and current active transcript text at the same time, the highlighted active transcript text should move up to be adjacent with the media player (not below it).

Ramp seems to implement the highlighted active transcript text in the middle of the transcript tab, so this might need to be an Avalon customization?

Location of active transcript text on my screen without scrolling:

image (5).png

Transcript text continues below the fold when I scroll down:

image (6).png

Done looks like

  • The currently active, highlighted transcript text cue remains at the top of the component area when auto-scroll is enabled:
    Screenshot 2024-02-28 at 2 08 47 PM

Screenshot 2024-02-28 at 2 09 44 PM

  • If the transcript component is at the end of the transcript, then the highlight can move down the list of cues until it goes to the bottom of the element:

Screenshot 2024-02-28 at 2 53 51 PM

Screenshot 2024-02-28 at 2 53 59 PM

@joncameron joncameron changed the title Active Cue in Transcript Component is Too Low Visually Change Placement of Active Cue in Transcript Component Feb 28, 2024
@joncameron
Copy link
Contributor Author

This will be a matter of changing the calculation to place the active cue at the top instead of the middle.

@joncameron
Copy link
Contributor Author

This works great and as expected on the Ramp demo site but it doesn't look like it made it to avalon-dev.

@Dananji did the Ramp build PR #5789 get overwritten by another Ramp build to dev?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants