Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Caption File References from HLS Manifest #5722

Closed
1 of 3 tasks
joncameron opened this issue Mar 12, 2024 · 2 comments
Closed
1 of 3 tasks

Remove Caption File References from HLS Manifest #5722

joncameron opened this issue Mar 12, 2024 · 2 comments
Assignees

Comments

@joncameron
Copy link
Contributor

joncameron commented Mar 12, 2024

Description

See #5695 for details on why captions are being removed from the HLS manifest. In short, having captions in the HLS manifest and also delivered via IIIF manifest means ambiguity and difficulty in the media player environment across browsers.

Currently, captions are in the manifest for an item like this in the HLS manifest:
#EXT-X-MEDIA:TYPE=SUBTITLES,GROUP-ID="subs",LANGUAGE="en",NAME="English",AUTOSELECT=YES,URI="/master_files/0p096d77r/caption_manifest"
This can be removed.

Done Looks Like

  • Caption references do not appear in Avalon's HLS manifests
  • Re-test to ensure that captions do display on iOS devices in the native player
  • Ensure that HLS player is using the IIIF manifest, rather than HLS captions
@masaball masaball self-assigned this Mar 12, 2024
@masaball
Copy link
Contributor

masaball commented Mar 13, 2024

I was unable to test with my local system because I could not get Browserstack iOS to work with localhost. From testing on desktop, the current Ramp build in Dev is removing the non-HLS captions from the track listing so when the player instantiates, the captions button is present for a split second and then disappears. I think this is because we have not brought in a build containing samvera-labs/ramp#428 yet. Once that is brought in, captions should display as expected. I did test manifests from Avalon on the Ramp demo site and everything looked good.

Captions in the embedded player were working as expected for desktop, but I could not test on iOS for the same localhost issues already mentioned.

@elynema
Copy link
Contributor

elynema commented Mar 14, 2024

Once the Ramp build with #428 is brought in, this can be tested on avalon-dev. Ramp PR #443 is complementary work to remove Ramp code that handles duplicate captions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants