Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Files tab is showing up when there are only transcript files #6192

Open
1 of 5 tasks
elynema opened this issue Feb 10, 2025 · 1 comment
Open
1 of 5 tasks

[BUG] Files tab is showing up when there are only transcript files #6192

elynema opened this issue Feb 10, 2025 · 1 comment
Assignees
Labels

Comments

@elynema
Copy link
Contributor

elynema commented Feb 10, 2025

Describe the bug
Due to transcript files being downloadable from the transcript tab, we stopped displaying them on the Files tab (to prevent redundancy). However, the Files tab now shows up with the message "No Supplemental file(s) in Manifest" when there is only a transcript file.

To Reproduce
Steps to reproduce the behavior, including the results:

  1. Go to https://media.dlib.indiana.edu/media_objects/1v53kc546
  2. Click on Files tab
  3. See error

Expected behavior
The Files tab should not be rendered if there are no files to list for download. If there are only transcript files(s) available as supplemental files, the File tab should not be rendered.

Screenshots/Screen Recording
image.png

Environment (please complete the following information):

  • Device / platform: MacOS laptop
  • OS: Sequoia
  • Browser: Chrome
  • avalon-dev
  • avalon-staging
  • mco-staging
  • mco-production
  • demo

Release:
I am guessing this was introduced in Release 7.8, but have not tested to be sure?

Additional notes
I anticipate this issue will show up on avalon-dev and mco-staging, as well.

@elynema
Copy link
Contributor Author

elynema commented Feb 12, 2025

Pass a variable to Ramp based on whether a media item has supplemental files present. Current code is not set up to distinguish transcripts from other supplemental files. Need to adjust the scoping on the hasFiles check.

There was a behavior change in #5729, where we decided to no longer display transcripts on the Files tab because they are downloadable from the Transcripts tab. I believe the motivator was that we didn't want captions that are being treated as transcripts to be displayed twice. We accomplished this by removing transcripts from the property. This is probably still reasonable.

An alternate solution to that problem would be to allow all transcripts to display in Files tab and then have Ramp de-dupe between captions and transcripts. That would require re-adding the transcripts to the property and deciding on a good way to de-dupe. As this feels like more of a local use case, it seems like it makes more sense to handle in Avalon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants