Remove unneeded arguments and methods from page controller file.

Author: rmcgirr83

config/services.yml

@@ -4,18 +4,9 @@ services:
         arguments:
             - '@config'
             - '@controller.helper'
-            - '@auth'
-            - '@template'
-            - '@dbal.conn'
-            - '@request'
-            - '@user'
-            - '@pagination'
-            - '%core.php_ext%'
-            - '@path_helper'
-            - '@ext.manager'
-            - '%core.root_path%'
-            - '@paybas.recenttopics.functions'
             - '@language'
+            - '@paybas.recenttopics.functions'
+
     paybas.recenttopics.functions:
         class: paybas\recenttopics\core\recenttopics
         arguments:

controller/page_controller.php

@@ -10,66 +10,28 @@
 
 namespace paybas\recenttopics\controller;
 
+use phpbb\config\config;
+use phpbb\controller\helper;
 use phpbb\language\language;
+use paybas\recenttopics\core\recenttopics;
+use Symfony\Component\HttpFoundation\Response;
 
 class page_controller implements page_interface
 {
-	/**
-	 * @var \phpbb\auth\auth
-	 */
-	protected $auth;
 	/**
 	 * @var \phpbb\config\config
 	 */
 	protected $config;
+
 	/**
 	 * @var \phpbb\controller\helper
 	 */
 	protected $helper;
+
 	/**
-	 * @var \phpbb\template\template
-	 */
-	protected $template;
-	/**
-	 * @var \phpbb\db\driver\driver_interface
-	 */
-	protected $db;
-	/**
-	 * @var \phpbb\request\request
-	 */
-	protected $request;
-	/**
-	 * @var \phpbb\user
-	 */
-	protected $user;
-	/**
-	 * @var string
-	 */
-	protected $phpEx;
-	/**
-	 * @var \phpbb\pagination
-	 */
-	protected $pagination;
-	/**
-	 * @var \phpbb\extension\manager
-	 */
-	protected $phpbb_extension_manager;
-	/**
-	 * @var string
-	 */
-	protected $ext_path;
-	/**
-	 * @var string
-	 */
-	protected $ext_path_web;
-	/**
-	 * @var string
-	 */
-	protected $ext_path_images;
-	/**
-	 * @var string
+	 * @var language
 	 */
-	protected $root_path;
+	protected $language;
 
 	/* @var recenttopics */
 	protected $rt_functions;
@@ -79,72 +41,25 @@ class page_controller implements page_interface
 	 */
 	protected $response;
 
-	/**
-	 * @var language
-	 */
-	protected $language;
-
-	/**
-	 * @var string
-	 */
-	protected $php_ext;
-
-	/**
-	 * @var string
-	 */
-	protected $path_helper;
-
 	/**
 	 * page constructor.
 	 *
-	 * @param \phpbb\config\config              $config
-	 * @param \phpbb\controller\helper          $helper
-	 * @param \phpbb\auth\auth                  $auth
-	 * @param \phpbb\template\template          $template
-	 * @param \phpbb\db\driver\driver_interface $db
-	 * @param \phpbb\request\request            $request
-	 * @param \phpbb\user                       $user
-	 * @param \phpbb\pagination                 $pagination
-	 * @param $php_ext
-	 * @param \phpbb\path_helper                $path_helper
-	 * @param \phpbb\extension\manager          $phpbb_extension_manager
-	 * @param $root_path
-	 * @param \paybas\recenttopics\core\recenttopics $functions
-	 * @param \phpbb\language\language $language
+	 * @param \phpbb\config\config              		$config
+	 * @param \phpbb\controller\helper          		$helper
+	 * @param \phpbb\language\language 					$language
+	 * @param \paybas\recenttopics\core\recenttopics	$functions
 	 */
 	public function __construct(
-		\phpbb\config\config $config,
-		\phpbb\controller\helper $helper,
-		\phpbb\auth\auth $auth,
-		\phpbb\template\template $template,
-		\phpbb\db\driver\driver_interface $db,
-		\phpbb\request\request $request,
-		\phpbb\user $user,
-		\phpbb\pagination $pagination,
-		$php_ext,
-		\phpbb\path_helper $path_helper,
-		\phpbb\extension\manager $phpbb_extension_manager,
-		$root_path,
-		\paybas\recenttopics\core\recenttopics $functions,
-		\phpbb\language\language $language
+		config $config,
+		helper $helper,
+		language $language,
+		recenttopics $functions
 	)
 	{
 		$this->config       = $config;
 		$this->helper       = $helper;
-		$this->auth         = $auth;
-		$this->template     = $template;
-		$this->db           = $db;
-		$this->request      = $request;
-		$this->user         = $user;
-		$this->pagination   = $pagination;
-		$this->php_ext      = $php_ext;
-		$this->path_helper  = $path_helper;
-		$this->phpbb_extension_manager = $phpbb_extension_manager;
-		$this->ext_path     = $this->phpbb_extension_manager->get_extension_path('paybas/recenttopics', true);
-		$this->ext_path_web = $this->path_helper->get_web_root_path();
-		$this->root_path  = $root_path;
-		$this->rt_functions = $functions;
 		$this->language = $language;
+		$this->rt_functions = $functions;
 	}
 
 	/**
@@ -156,8 +71,7 @@ public function __construct(
 	public function display()
 	{
 		$page = "recent_topics_page.html";
-		$this->language->add_lang('info_acp_recenttopics', 'paybas/recenttopics');
-		$this->language->add_lang('recenttopics', 'paybas/recenttopics');
+		$this->language->add_lang(['info_acp_recenttopics', 'recenttopics'], 'paybas/recenttopics');
 
 		if (isset($this->config['rt_index']) && $this->config['rt_index'])
 		{