fix(ngRoute): improve interpolation of params in string

When the redirect path contains optional or special parameters the
interpolation function misses to remove them.

This is also the case for the auto-generated redirection where a slash
is appended or removed to a route.

Change the way parameters are interpolated in a string. Remove undefined
optional named groups and properly prepend a slash in case the named
group was starting with one.

Related to angular#5746.

Author: avdv

src/ngRoute/route.js

@@ -606,19 +606,20 @@ function $RouteProvider(){
      * @returns {string} interpolation of the redirect path with the parameters
      */
     function interpolate(string, params) {
-      var result = [];
-      angular.forEach((string||'').split(':'), function(segment, i) {
-        if (i === 0) {
-          result.push(segment);
+      return (string||'').replace(/(\/)?:(\w+)([?*])?/g, interpolateReplacer);
+
+      function interpolateReplacer(_, slash, key, option) {
+        var optional = option === '?';
+        var value = params[key];
+        delete params[key];
+
+        if (optional && value == null) {
+          return '';
         } else {
-          var segmentMatch = segment.match(/(\w+)(.*)/);
-          var key = segmentMatch[1];
-          result.push(params[key]);
-          result.push(segmentMatch[2] || '');
-          delete params[key];
+          slash = slash || '';
+          return slash + (value || '');
         }
-      });
-      return result.join('');
+      }
     }
   }];
 }