-
-
Notifications
You must be signed in to change notification settings - Fork 12k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change name for the package geo_pattern #305
Comments
Yep! Thank you. Just keep it alphabetized and that'll be good! (Feel free to submit a PR) |
I think it's absolutely fine to rename your package if you think it's better. You are the owner.
That page says the following:
I just want to point out, your new package name seems to be equally discouraged in that section like the old. Is that intentional? |
Ohh my god. This will obviously indicate that I was not functioning properly when I violated the rule, I wanted to follow. Sorry, my fault. Feeling apologetic. But a lesson learned.
Thanks @shurcooL, for pointing this out. So now, can somebody please suggest me, what to name it? |
I think |
Yeah! I'm also not a fan of this convention. All this, resulted in a nice version message though. 😄 Made a pull request #306 for it. Thanks for the help everyone. |
Hi folks,
Although the package is already there in the list in images section.
But today I made some changes to the project that also involves renaming it to geoPattern. Actually I was trying my best to follow the new golang blog, Package Names
GitHub usually redirects renamed projects very well but I just felt like asking to you all.
So, is this fine to change name for it or not?
The text was updated successfully, but these errors were encountered: