Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

empty error_handler labels #432

Merged
merged 3 commits into from
Feb 7, 2022
Merged

empty error_handler labels #432

merged 3 commits into from
Feb 7, 2022

Conversation

alex-schneider
Copy link
Contributor

@alex-schneider alex-schneider commented Feb 1, 2022

Fix and complete error message for empty error_handler labels


Reviewer checklist
  • Read PR description: a summary about the changes is required
  • Changelog updated
  • Documentation: docs/{Reference, Cli, ...}, Docker and cli help/usage
  • Pulled branch, manually tested
  • Verified requirements are met
  • Reviewed the code
  • Reviewed the related tests

config/configload/error_handler.go Outdated Show resolved Hide resolved
config/configload/error_handler.go Outdated Show resolved Hide resolved
@johakoch johakoch changed the title Fix and complete error message for empty error_handler labels empty error_handler labels Feb 7, 2022
@johakoch johakoch merged commit 353c628 into master Feb 7, 2022
@johakoch johakoch deleted the fix-error-message branch February 7, 2022 12:31
malud pushed a commit that referenced this pull request Mar 3, 2022
* Fix and complete error message for empty error_handler labels

* use more specific range for empty label; simpler error message

Co-authored-by: Johannes Koch <johannes.koch@avenga.com>
Co-authored-by: Johannes Koch <53434855+johakoch@users.noreply.github.com>
(cherry picked from commit 353c628)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants