Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Log list or map #535

Merged
merged 4 commits into from
Jul 8, 2022
Merged

Log list or map #535

merged 4 commits into from
Jul 8, 2022

Conversation

johakoch
Copy link
Collaborator

@johakoch johakoch commented Jul 5, 2022 •
edited
Loading

Allow cty.ListVal and cty.MapVal in convert function used for custom logs.

Reviewer checklist
  • Read PR description: a summary about the changes is required
  • Changelog updated
  • Documentation: docs/{Reference, Cli, ...}, Docker and cli help/usage
  • Pulled branch, manually tested
  • Verified requirements are met
  • Reviewed the code
  • Reviewed the related tests

@johakoch johakoch marked this pull request as ready for review July 5, 2022 14:14
@johakoch johakoch changed the base branch from master to release.1.9 July 7, 2022 07:44
@johakoch johakoch changed the base branch from release.1.9 to master July 7, 2022 07:45
@johakoch johakoch changed the base branch from master to release.1.9 July 7, 2022 08:41
@malud malud merged commit bbfa07d into release.1.9 Jul 8, 2022
@malud malud deleted the log-list-or-map branch July 8, 2022 06:59
malud pushed a commit that referenced this pull request Sep 8, 2022
@johakoch
Log list or map (#535) (#581)
4eb0e19 
* Use Is*Type() functions

* test for creating log fields for form body, cookies or headers

* fix: allow `cty.ListVal` and `cty.MapVal` in convert function used for custom logs

* changelog entry

Co-authored-by: Johannes Koch <53434855+johakoch@users.noreply.github.com>
malud pushed a commit that referenced this pull request Sep 8, 2022
@johakoch
Log list or map (#535) (#581)
0fe267d 
* Use Is*Type() functions

* test for creating log fields for form body, cookies or headers

* fix: allow `cty.ListVal` and `cty.MapVal` in convert function used for custom logs

* changelog entry

Co-authored-by: Johannes Koch <53434855+johakoch@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@malud malud malud approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@johakoch @malud