Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

client_secret_jwt and private_key_jwt #599

Merged
merged 17 commits into from
Nov 4, 2022
Merged

client_secret_jwt and private_key_jwt #599

merged 17 commits into from
Nov 4, 2022

Conversation

johakoch
Copy link
Collaborator

Implemented OAuth2 client authentication methods client_secret_jwt and private_key_jwt

Reviewer checklist
  • Read PR description: a summary about the changes is required
  • Changelog updated
  • Documentation: docs/{Reference, Cli, ...}, Docker and cli help/usage
  • Pulled branch, manually tested
  • Verified requirements are met
  • Reviewed the code
  • Reviewed the related tests

@johakoch johakoch force-pushed the client_secret_jwt-private_key_jwt branch 2 times, most recently from cbc9d7d to 949da26 Compare September 20, 2022 16:15
@johakoch johakoch force-pushed the client_secret_jwt-private_key_jwt branch from df4ae58 to 74a88f8 Compare October 20, 2022 15:34
Johannes Koch added 14 commits October 21, 2022 16:08
constants for client authentication methods
8119f98
use switch to check supported client authn methods
c4b8354
store authn method in client; use switch when authenticating request
4d58d35
harmonize documentation of token_endpoint_auth_method
8c7995e
documented new values for token_endpoint_auth_method
2959a77
allow new values for token_endpoint_auth_method
58a9c5f
new config attributes
b6958a9
implement client_secret_jwt and private_key_jwt
cc228fc
authn_x5t_header to use private_key_jwt with azure
7a76abd
some more config checks and tests for config errors
0fa7f36
integration test for client_secret_jwt and private_key_jwt: the created
d83f78d 
JWT is validated at the AS's token endpoint; some claims are passed in
the access token to the client to further check them at the RS; the x5t
header is not tested (yet)
changelog entry
6624027
use jwt_signing_profile instead of various attributes
21ec52b
go fmt, docs format
13608de
@johakoch johakoch force-pushed the client_secret_jwt-private_key_jwt branch from 74a88f8 to 13608de Compare October 21, 2022 14:45
@johakoch johakoch marked this pull request as ready for review October 21, 2022 15:39
alex-schneider
alex-schneider previously approved these changes Nov 3, 2022
View reviewed changes
alex-schneider
alex-schneider previously approved these changes Nov 3, 2022
View reviewed changes
@alex-schneider alex-schneider merged commit 8527c98 into master Nov 4, 2022
@alex-schneider alex-schneider deleted the client_secret_jwt-private_key_jwt branch November 4, 2022 08:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alex-schneider alex-schneider alex-schneider approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@johakoch @alex-schneider