-
Notifications
You must be signed in to change notification settings - Fork 113
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Why is 405 Method Not Allowed always returned? #170
Comments
Ah, I found the culprit. If uncomment the root option, then it works, no 405. Weird. Probably the connect.directory middleware is messing here with something else |
Hmmm, serve-index causes this. See line https://github.com/expressjs/serve-index/blob/master/index.js#L102 ... uhhhh :( |
a solution would be to rearrange the order. to run the custom middleware first before serve-index |
@justinmchase ping |
I think this commit broke it Order of middleware is crucial. Please restore. |
I'm swamped right now but took a look at it and didn't see any obvious reason why the order of the middleware would be changed. Can you send a PR, or at least help me narrow down where the issue is happening? If I generally knew a fix I could probably crank it out in hours, sorry for delay. |
@justinmchase here you go, it is very simple #171 |
Fixed in v3.1.1 |
great, the error is gone now, all works fine like before. thanks for quick reaction |
ps: @justinmchase can you please look at #140? |
This on POST requests.
It is this code for reproduction:
https://github.com/binarykitchen/videomail-client/blob/master/Gulpfile.js#L104
The text was updated successfully, but these errors were encountered: