Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for automatic logging at the beginning and end of subflows #43

Open
claytonflesher opened this issue Jul 21, 2022 · 3 comments

Comments

@claytonflesher
Copy link

Just as v2 has automatic logging for beginning and end of flows, add support for this in subflows as well.
Use the same flow logs checkbox there is now, just for subflows.

@manikmagar
Copy link
Contributor

Flow execution logging is based on the notifications provided by the runtime. There are no similar notifications for Subflow which ultimately just executes in the same context as the calling flow. We could check flow-ref processor notifications and see if logging the start and end of that processor will help. Although, when calling async actions, the logs may not represent sub-flows execution.

@manikmagar
Copy link
Contributor

manikmagar commented Mar 13, 2024

@adesjardin @claytonflesher We implemented flow-ref span capture for the OTEL module by using a flow-ref interceptor and detecting if the target is a sub-flow or flow. We could use the same strategy to enable sub-flow start and end logs.

@manikmagar
Copy link
Contributor

This can also be done with notifications for a flow-ref processor with sub-flow as a target. Log the start and end of the flow-ref processor with the target name.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants