Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added the possibility of configura a fallback file #18

Merged
merged 15 commits into from
Sep 20, 2022
Merged

Added the possibility of configura a fallback file #18

merged 15 commits into from
Sep 20, 2022

Conversation

Olorinn
Copy link
Contributor

@Olorinn Olorinn commented Aug 23, 2022

No description provided.

adammead
adammead reviewed Aug 25, 2022
View reviewed changes
Copy link
Contributor

@adammead adammead left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I left a couple of inline comments.

...oconsulting/mule/vault/provider/internal/connection/provider/AbstractConnectionProvider.java Outdated Show resolved Hide resolved
...in/java/com/avioconsulting/mule/vault/provider/api/VaultConfigurationPropertiesProvider.java Outdated Show resolved Hide resolved
@adammead adammead linked an issue Sep 2, 2022 that may be closed by this pull request
Add ability to fallback to properties file in the case of unit test environment #2
Open
Olorinn and others added 12 commits September 8, 2022 09:37
@Olorinn
Merge branch 'develop' into feature/add-fallback-file
125a4a6
@Olorinn
Fixes raised in the PR
ea9048b
@adammead
Changed fallback mode to localMode and added parameter to enable/disa…
ed08878 
…ble it
@adammead
Improve Javadoc comments and extract VaultPropertyPath to help with u…
b82862a 
…nit testing
@FranRodriguezRojas
adding tests for VaultConfigurationPropertiesProvider file fallback o…
31cdaf7 
…ption
@FranRodriguezRojas
adding tests for VaultConfigurationPropertiesProvider file fallback o…
c45fbfb 
…ption
@FranRodriguezRojas
PR comments resolved
b9992d9
@adammead
Merge pull request #22 from avioconsulting/feature/add-fallback-file-…
b60dbd0 
…enhance-tests

Feature/add fallback file enhance tests
@FranRodriguezRojas
reverting DefaultconfigurationProperty.
fe7a1e3
@FranRodriguezRojas
updating pom.xml to fix integration tests issue.
d124b8e
@adammead
Merge pull request #23 from avioconsulting/feature/add-fallback-file-…
3ce32bd 
…enhance-tests

reverting DefaultconfigurationProperty.
@adammead
Clean up imports
736fd63
@adammead adammead merged commit 0351707 into develop Sep 20, 2022
@adesjardin adesjardin deleted the feature/add-fallback-file branch June 21, 2023 20:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adesjardin adesjardin adesjardin requested changes

@adammead adammead adammead approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add ability to fallback to properties file in the case of unit test environment
4 participants
@Olorinn @adesjardin @adammead @FranRodriguezRojas