Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate away from Bettercloud Vault Client #21

Open
adammead opened this issue Sep 2, 2022 · 3 comments
Open

Migrate away from Bettercloud Vault Client #21

adammead opened this issue Sep 2, 2022 · 3 comments

Comments

@adammead
Copy link
Contributor

adammead commented Sep 2, 2022

The Bettercloud client is no longer supported - see this comment. As such, we should migrate away from it to another client implementation that can be shared with the Vault Connector.

@neckron
Copy link

neckron commented Sep 22, 2022

Hi @adammead / @adesjardin

I was analyzing this issue, correct me please if I missunderstood the AS-IS.

AS-IS

image

TO-BE (proposal)

image

Please let me know what do you think about this approach.

@adammead
Copy link
Contributor Author

Hi @neckron,

I don't think we want to use the mule-http-connector dependency of the client. We want to use the Mule HTTP client (org.mule.runtime.http.api.client.HttpClient) since that is required for MuleSoft certification. Other than that, the approach looks good.

I think the new library should be called vault-http-client since it's not a MuleSoft connector, but rather a Vault client library.

@tledkov
Copy link

tledkov commented Oct 9, 2022

@adammead I'm sorry for inconvenient.

I've forked the vault-java-driver as io.github.jopenlibs:vault-java-driver the project of simple open source github organization.
I'm going to support it by review & deploy sometimes. Any developer can join to the simple organization.

It seems to me that the advantage of the organization is that when changing the developer, it will not be necessary to change the group of artifacts.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants