Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dynamic Diagrams are rendered, but not displayed #234

Closed
mariusburfey opened this issue May 26, 2023 · 4 comments · Fixed by #333
Closed

Dynamic Diagrams are rendered, but not displayed #234

mariusburfey opened this issue May 26, 2023 · 4 comments · Fixed by #333

Comments

@mariusburfey
Copy link

Hey everyone and thank you for building this awesome tool!
I am currently evaluating whether we want to use it in combination with Gitlab Pages for our engineers. It looks very promising!

But I am wondering, whether Dynamic Diagrams are supported: The diagrams are rendered (as puml, svg and png, everything seems fine), but I can't find them on the website. Are they displayed anywhere or does this feature not (yet) exist?

The example contains such a diagram called "SignIn".

Thanks and best regards,
Marius

@mariusburfey mariusburfey changed the title Dynamic Dynamic Diagrams are rendered, but not displayed May 26, 2023
@jp7677
Copy link
Contributor

jp7677 commented May 26, 2023

There is currently indeed no dedicated page for showing dynamic diagrams. I don’t know/remember if there is a specific reason for that, I guess we just haven’t had the need for that.

What you can do however, is to embed those diagrams in a markdown document and add the document as documentation to your software system (see https://github.com/avisi-cloud/structurizr-site-generatr/blob/main/docs/example/workspace-docs/01-embedding-diagrams-and-images.md as an example).

@mariusburfey
Copy link
Author

Thanks!
This works fine for me.

@jp7677
Copy link
Contributor

jp7677 commented May 26, 2023

Cool to hear. That said I think it would actually be a good idea to also show dynamic diagrams on a dedicated page like we do with deployment diagrams.
Let’s keep this issue open as a reminder.

@jp7677 jp7677 reopened this May 26, 2023
@jeremyjousse
Copy link

@jp7677 The main interest of dynamic diagrams is also to use them as a sequence diagram, and use the next/previews/play "dynamic" feature. A simple SVG is losing interest 😞 .
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants