Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cannot decode images from Structurizr AWS 2020 theme #639

Closed
ad737079 opened this issue Nov 25, 2024 · 6 comments
Closed

Cannot decode images from Structurizr AWS 2020 theme #639

ad737079 opened this issue Nov 25, 2024 · 6 comments

Comments

@ad737079
Copy link

ad737079 commented Nov 25, 2024

Currently if you try to use the AWS 2020 theme from https://docs.structurizr.com/ui/diagrams/themes every diagram that uses a AWS image generates incorrectly with the following error in place of each logo:

(Cannot decode: https://static.structurizr.com/themes/amazon-web-services-2020.04.30/AWS-Cloud_light-bg@4x.png)

This does not happen with the 2022 and 2023 themes, so I assume its something to do with the @ symbol thats been added to the image paths within the theme definition as this isn't present in the other themes.

Can reproduce by using any of the theme tags in a DSL and running generate-site, e.g.:

deploymentNode "AWS" { tags "Amazon Web Services - Cloud" }

@ad737079 ad737079 changed the title Cannot decode images from Structurizr AWS theme Cannot decode images from Structurizr AWS 2020 theme Nov 25, 2024
@jenspav
Copy link
Collaborator

jenspav commented Nov 25, 2024

Do you have a minimal but complete model at hand which easily reproduces this issue?

@ad737079
Copy link
Author

ad737079 commented Nov 25, 2024

Yes, using the default Structurizr Example:

workspace "Test" "A test" {
    model {
        u = person "User"
        ss = softwareSystem "Software System" {
            wa = container "Web Application"
            db = container "Database Schema" {
                tags "Amazon Web Services - Cloud"
            }
        }
    }

    views {
        properties {
            "generatr.site.exporter" "structurizr"
        }

        container ss "Diagram2" {
            include *
            autolayout lr
        }

        themes default https://static.structurizr.com/themes/amazon-web-services-2020.04.30/theme.json
    }
}

Results in:

Screenshot 2024-11-25 at 16 27 44

@jenspav
Copy link
Collaborator

jenspav commented Nov 26, 2024

Thanks for the example! Looks like the diagram generation itself went fine, the error is baked in into the svg/png. So it doesn't look like our issue. Running your example at https://structurizr.com/dsl , I can reproduce this there with the planuml and C4-plantuml export (I've added view property "c4plantuml.tags" "true" for that).

Could you please open an issue at https://github.com/structurizr/java/tree/master/structurizr-export and report it there as well?

@ad737079
Copy link
Author

Done - structurizr/themes#17

@ad737079
Copy link
Author

Now fixed upstream, closing this issue.

@jenspav
Copy link
Collaborator

jenspav commented Jan 27, 2025

Thanks for the heads-up!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants