Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inconsistent slash in links generation from markdown ADRs to HTML pages #655

Closed
makaxel opened this issue Dec 16, 2024 · 2 comments · Fixed by #656
Closed

Inconsistent slash in links generation from markdown ADRs to HTML pages #655

makaxel opened this issue Dec 16, 2024 · 2 comments · Fixed by #656

Comments

@makaxel
Copy link

makaxel commented Dec 16, 2024

Reproducing:

Create some ADR with crosslinks by adr-tool (or by hands)

adr init
adr new Implement Feature1
adr new -s 2 Another Realisation of F2

We'll got
in 0002-implement-feature1.md
Superseded by [3. Another Realisation of F2](0003-another-realisation-of-f2.md)

in 0003-another-realisation-of-f2.md
Supersedes [2. Implement Feature1](0002-implement-feature1.md)

Generate docs
We'll got
correct links in structurizr/build/site/master/decisions/index.html

<td><a href="2/" class="">Implement Feature1</a></td>
<td><a href="3/" class="">Another Realisation of F2</a></td>

but links without slash in structurizr/build/site/master/decisions/2/index.html and in structurizr/build/site/master/decisions/3/index.html
<p>Superseded by <a href="../3">3. Another Realisation of F2</a></p>
and
<p>Supersedes <a href="../2">2. Implement Feature1</a></p>

Maybe some sort relevant to #530 and #543
Please fix.
Thanks.

@jenspav
Copy link
Collaborator

jenspav commented Dec 17, 2024

Thanks for the report. Yes, we should be consistent there. Does #656 fixes this for your?

@makaxel
Copy link
Author

makaxel commented Dec 19, 2024

Thank you for quick fix! Yes, now it works fine. Checked by running sources from IDEA with yours example and mine.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants