Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Why not just use Python Packages -Nobody uses the old grandfather called MATLAB #2

Open
developeralgo8888 opened this issue Dec 17, 2016 · 8 comments

Comments

@developeralgo8888
Copy link

developeralgo8888 commented Dec 17, 2016

It is waste of time to learn 2 libraries especially damn MATLAB. I have not used MATLAB since i left University 6 years ago and never come across any company in real world using MATLAB . In some die-hard colleges that don't want to let go still use MATLAB but majority have moved on to python .
There are Tensorflow , Theano and others that would accomplish the same task probably in easier way and help majority of people adopt your research

@avivt
Copy link
Owner

avivt commented Dec 17, 2016

Well, my university training focused more on theory, and Matlab was the main tool, so when I started working on this project I coded some of it in Matlab. For research, Matlab's IDE still offers some advantages for quickly analyzing results, in my opinion.

But I agree, it would be great to convert the Matlab code to python. For an experienced python programmer this shouldn't take much time, and if you're interested in taking this on I'd be glad to assist. At present, I don't have the bandwidth to take this on myself.

@developeralgo8888
Copy link
Author

thanks Avivt,
i will try to migrate it to tensorflow /theano and python

@avivt
Copy link
Owner

avivt commented Dec 18, 2016

Awesome!

@developeralgo8888
Copy link
Author

developeralgo8888 commented Dec 21, 2016

Time is not on myside at the moment. i wish you could have written it in tensorFlow since you understand the experiments and your research better it would probably take you less than 3 hours to convert the entire code to tensorflow. Then we can further push your research and adopt it more. If i get a chance after the christmas holidays , i will give it a short

@DanielTakeshi
Copy link

Seems like VIN are implemented here using Python:

https://github.com/TheAbhiKumar/tensorflow-value-iteration-networks

@developeralgo8888
Copy link
Author

Actually i tested it but its not stable at all. it works only for Gridworld-8 but not on image size 16 and 28 . But even with Gridworld-8 it is not stable at all

@kentsommer
Copy link

kentsommer commented Apr 21, 2017

@avivt @developeralgo8888

I have a full python + pytorch + numpy implementation of the gridworld experiments. I am happy to PR that to a new "python" branch for this repository or keep the release in my own repository. Let me know which you would prefer.

Thanks,
Kent

@avivt
Copy link
Owner

avivt commented Apr 21, 2017

Hi Kent,
This is really great!!
I think it's best to keep the code in your own repo, and I'll add a link to it on the info page.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants