Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Verify the checksum for the downloaded components #9

Open
yanghua opened this issue Jan 5, 2024 · 3 comments
Open

Verify the checksum for the downloaded components #9

yanghua opened this issue Jan 5, 2024 · 3 comments
Labels
infra build, compose and so on

Comments

@yanghua
Copy link
Contributor

yanghua commented Jan 5, 2024

Sometimes, the download actions for some components are not successful due to network issues. However, the broken files have existed. So, when we invoke the download command once again, the command would skip these broken files.

IMO, it would be better to verify the checksum for the downloaded components to make sure the files are completed.

@yanghua
Copy link
Contributor Author

yanghua commented Jan 5, 2024

@pan3793 WDYT?

@pan3793
Copy link
Member

pan3793 commented Jan 5, 2024

I have thought, but this may increase the cost for users who want to use their custom version components. But it's OK if we can have a switch(maybe an env var named CHECKSUM_ENABLED) to allow user to disable it.

@yanghua yanghua added the infra build, compose and so on label Feb 6, 2024
@pan3793
Copy link
Member

pan3793 commented Dec 5, 2024

I found a common case in daily usage, the wrongly assembled URL would produce a zero size download/foo.tgz, and then cause the foo.tgz to be skipped to download in the next round even with the corrected URL

wget -O download/foo.tgz https://wrong/path/foo.tgz

fb43115 added a simple mechanism to auto delete zero size file in download_if_not_exists

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
infra build, compose and so on
Projects
None yet
Development

No branches or pull requests

2 participants