Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Action does not support EKS pod identities #624

Open
casey-robertson-paypal opened this issue May 7, 2024 · 1 comment
Open

Action does not support EKS pod identities #624

casey-robertson-paypal opened this issue May 7, 2024 · 1 comment

Comments

@casey-robertson-paypal
Copy link

casey-robertson-paypal commented May 7, 2024

Describe the bug
We are migrating workloads to EKS - in particular Github Actions runners. The runner scalesets run as service accounts wired up to AWS EKS Pod Identities. We run v2 of the action and receive the following error:

Run aws-actions/amazon-ecr-login@v2
  with:
    mask-password: true
    registry-type: private
    skip-logout: false
Error: 169.254.170.23 is not a valid container metadata service hostname

To Reproduce

Create a test action that uses amazon-ecr-login in a pod/runner running in EKS and a service account identity.

Expected behavior
The action discovers the creds mounted in the metadata path and uses them to authenticate with ECR.

Screenshots
No screenshots but we confirmed that raw aws sts commands are returning the correct assumed role that we'd expect.

Desktop (please complete the following information):
EKS 1.29
Running 0.9.0 version of github action runner container and helm chart.

@meithon
Copy link

meithon commented Oct 3, 2024

Current Workaround
At present, one of the most effective solutions appears to be using the following action instead:

- name: Login to Amazon ECR
  id: login-ecr
  run: |
    aws ecr get-login-password --region $AWS_REGION | docker login --username AWS --password-stdin xxxxxxxxxxxx.dkr.ecr.ap-northeast-1.amazonaws.com

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants