Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support native installers #68

Closed
hoffa opened this issue Jan 24, 2023 · 3 comments
Closed

Support native installers #68

hoffa opened this issue Jan 24, 2023 · 3 comments
Labels
enhancement New feature or request

Comments

@hoffa
Copy link
Contributor

hoffa commented Jan 24, 2023

Currently setup-sam uses pip to install SAM CLI. It makes multi-platform support trivial, but means issues can occur due to transient dependencies changing (e.g. #64 or #41). It also means Python has to be installed for setup-sam to work (although it isn't typically a problem in practice; GitHub-hosted runners include it).

Using the official installers would minimize dependency issues and get rid of the setup-python dependency. And perhaps makes #12 easier? One potential issue is SAM CLI doesn't currently support Linux ARM (see aws/aws-sam-cli#3908).

No need to run the install script, and can use dist/sam directly instead. Might help with caching.

Should probably push a v3, as the python input will be removed, and don't want to break changes such as #64 (comment).

@hoffa hoffa added the enhancement New feature or request label Jan 24, 2023
@hoffa hoffa changed the title Support official installers Support native installers Mar 1, 2023
@hoffa
Copy link
Contributor Author

hoffa commented Mar 1, 2023

Done in #70 for Linux x86-64; which is also ubuntu-latest so assuming the most common. Resolving in favor of more granular ones.

@hoffa hoffa closed this as completed Mar 1, 2023
@aidansteele
Copy link

Sorry for the spam, but I just wanted to say thank you so much @hoffa. This change has halved the runtime of my entire pipeline for the (fairly common) case of no changes needing deployment. Even when there are changes to deploy, it's going to make a substantial difference - and make our devs happier with submitting PRs. ❤️

CleanShot 2023-03-02 at 09 53 45@2x

@hoffa
Copy link
Contributor Author

hoffa commented Mar 1, 2023

@aidansteele Thanks for you comment, that's great to hear!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants