Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(storage): add delimiter support #2871

Merged
merged 11 commits into from
Jul 24, 2024
Merged

feat(storage): add delimiter support #2871

merged 11 commits into from
Jul 24, 2024

Conversation

phantumcode
Copy link
Member

@phantumcode phantumcode commented Jul 16, 2024 •
edited
Loading

  • PR title and description conform to Pull Request guidelines.

Issue #, if available:

Description of changes:

  • Add support for AWS S3 Storage delimiter

How did you test these changes?

  • Unit tests and integration tests added
  • Manual test verified that the correct storage item lists are returned

Documentation update required?

General Checklist

  • Added Unit Tests
  • Added Integration Tests
  • Security oriented best practices and standards are followed (e.g. using input sanitization, principle of least privilege, etc)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@phantumcode phantumcode marked this pull request as ready for review July 17, 2024 18:29
@phantumcode phantumcode requested review from a team as code owners July 17, 2024 18:29
mattcreaser
mattcreaser reviewed Jul 23, 2024
View reviewed changes
Copy link
Member

@mattcreaser mattcreaser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Main thing is to add overloads to the two listFiles apis

aws-storage-s3/src/main/java/com/amplifyframework/storage/s3/service/StorageService.java Show resolved Hide resolved
aws-storage-s3/src/main/java/com/amplifyframework/storage/s3/service/StorageService.java Show resolved Hide resolved
aws-storage-s3/api/aws-storage-s3.api Show resolved Hide resolved
...-s3/src/test/java/com/amplifyframework/storage/s3/operation/AWSS3StorageListOperationTest.kt Show resolved Hide resolved
aws-storage-s3/src/main/java/com/amplifyframework/storage/s3/service/AWSS3StorageService.kt Outdated Show resolved Hide resolved
aws-storage-s3/src/main/java/com/amplifyframework/storage/s3/service/AWSS3StorageService.kt Show resolved Hide resolved
lawmicha
lawmicha previously approved these changes Jul 24, 2024
View reviewed changes
Copy link
Member

@lawmicha lawmicha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let me know if you need re-approval after addressing remaining comments

@phantumcode phantumcode merged commit cf64793 into main Jul 24, 2024
3 checks passed
@phantumcode phantumcode deleted the feature/storage_delimiter branch July 24, 2024 17:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mattcreaser mattcreaser mattcreaser approved these changes

@lawmicha lawmicha lawmicha approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@phantumcode @lawmicha @mattcreaser