Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(api): Pass authorization in header instead of query parameter for API category #2918

Merged
merged 4 commits into from
Sep 24, 2024

Conversation

mattcreaser
Copy link
Member

  • PR title and description conform to Pull Request guidelines.

Issue #, if available:

Description of changes:
AppSync now supports passing the authorization headers as HTTP headers instead of query string parameters when establishing a websocket connection.

This PR migrates the API category to the new, recommended method for passing authorization headers.

How did you test these changes?

  • Manual test
  • Integration tests

Documentation update required?

  • No
  • Yes (Please include a PR link for the documentation update)

General Checklist

  • Added Unit Tests
  • Added Integration Tests
  • Security oriented best practices and standards are followed (e.g. using input sanitization, principle of least privilege, etc)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@mattcreaser mattcreaser marked this pull request as ready for review September 17, 2024 18:17
@mattcreaser mattcreaser requested a review from a team as a code owner September 17, 2024 18:17
vincetran
vincetran previously approved these changes Sep 17, 2024
tylerjroach
tylerjroach previously approved these changes Sep 17, 2024
Copy link

codecov bot commented Sep 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 44.03%. Comparing base (7f874ed) to head (3689636).
Report is 9 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2918      +/-   ##
==========================================
+ Coverage   44.01%   44.03%   +0.01%     
==========================================
  Files         926      932       +6     
  Lines       30485    30689     +204     
  Branches     4351     4496     +145     
==========================================
+ Hits        13419    13513      +94     
- Misses      15601    15693      +92     
- Partials     1465     1483      +18     

@mattcreaser mattcreaser merged commit 5cbc21b into main Sep 24, 2024
3 checks passed
@mattcreaser mattcreaser deleted the mattcreaser/appsync-header-api branch September 24, 2024 18:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants