Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

unable to use Function dependencies that require .node files #1153

Closed
josefaidt opened this issue Mar 14, 2024 · 1 comment · Fixed by #1197
Closed

unable to use Function dependencies that require .node files #1153

josefaidt opened this issue Mar 14, 2024 · 1 comment · Fixed by #1197
Assignees
Labels
feature-request New feature or request function Issue pertaining to Amplify Function

Comments

@josefaidt
Copy link
Contributor

Environment information

System:
  OS: macOS 14.3.1
  CPU: (10) arm64 Apple M1 Pro
  Memory: 105.50 MB / 32.00 GB
  Shell: /opt/homebrew/bin/fish
Binaries:
  Node: 20.11.1 - ~/Library/Caches/fnm_multishells/19127_1710431357384/bin/node
  Yarn: undefined - undefined
  npm: 10.2.4 - ~/Library/Caches/fnm_multishells/19127_1710431357384/bin/npm
  pnpm: 8.15.4 - ~/Library/Caches/fnm_multishells/19127_1710431357384/bin/pnpm
NPM Packages:
  @aws-amplify/backend: 0.13.0-beta.6
  @aws-amplify/backend-cli: 0.12.0-beta.6
  aws-amplify: 6.0.20
  aws-cdk: 2.132.1
  aws-cdk-lib: 2.132.1
  typescript: 5.4.2
AWS environment variables:
  AWS_PROFILE = josef-gen2
  AWS_STS_REGIONAL_ENDPOINTS = regional
  AWS_NODEJS_CONNECTION_REUSE_ENABLED = 1
  AWS_SDK_LOAD_CONFIG = 1
No CDK environment variables

NOTICES         (What's this? https://github.com/aws/aws-cdk/wiki/CLI-Notices)

29483(cli): Upgrading to v2.132.0 or v2.132.1 breaks cdk diff functionality

Overview: cdk diff functionality used to rely on assuming lookup-role.
With a recent change present in v2.132.0 and v2.132.1, it is
now trying to assume deploy-role with the lookup-role. This
leads to an authorization error if permissions were not
defined to assume deploy-role.

Affected versions: cli: >=2.132.0 <=2.132.1

More information at: https://github.com/aws/aws-cdk/issues/29483


If you dont want to see a notice anymore, use "cdk acknowledge <id>". For example, "cdk acknowledge 29483".

Description

Some packages such as https://www.npmjs.com/package/ssh2 require Node addons/.node files. esbuild does not support this without additional bundling settings as shown in evanw/esbuild#1051 (comment)

bundling: {
  loader: {
    ".node": "file",
  },
},
@josefaidt josefaidt added the pending-triage Incoming issues that need categorization label Mar 14, 2024
@josefaidt
Copy link
Contributor Author

marking as a feature request

@josefaidt josefaidt added feature-request New feature or request function Issue pertaining to Amplify Function and removed pending-triage Incoming issues that need categorization labels Mar 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature-request New feature or request function Issue pertaining to Amplify Function
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants