-
Notifications
You must be signed in to change notification settings - Fork 824
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(amplify-category-function): use ref for S3Bucket and S3Key in CFN #6358
Conversation
This pull request introduces 3 alerts when merging 3f0c9b0 into 7a045fb - view on LGTM.com new alerts:
|
Codecov Report
@@ Coverage Diff @@
## master #6358 +/- ##
========================================
Coverage 57.21% 57.21%
========================================
Files 474 474
Lines 21609 21609
Branches 4078 4295 +217
========================================
Hits 12364 12364
+ Misses 8384 8364 -20
- Partials 861 881 +20
Continue to review full report at Codecov.
|
packages/amplify-provider-awscloudformation/src/push-resources.ts
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
just one question, but LGTM
539c7cf
to
0624bd3
Compare
👏 🎉 thanks @jhockett |
Does this mean I have to manually update my existing functions? |
No, it should be taken care of automatically on the next |
My existing functions weren't updated. But I now see, that you have to touch the function. Eg adding a console.log, there by having the function recognized as updated, will trigger the changes in the cloudformation template. |
This pull request has been automatically locked since there hasn't been any recent activity after it was closed. Please open a new issue for related bugs. Looking for a help forum? We recommend joining the Amplify Community Discord server |
Issue #, if available:
Closes #5387
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.