Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: #6397 - auth update overwrite parameters #6403

Merged
merged 2 commits into from
Jan 26, 2021
Merged

fix: #6397 - auth update overwrite parameters #6403

merged 2 commits into from
Jan 26, 2021

Conversation

attilah
Copy link
Contributor

@attilah attilah commented Jan 16, 2021

Issue #, if available:

fix: #6397 - auth update overwrite parameters

Description of changes:

Fixes an auth update scenario, when trigger defined properties were overwritten.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@attilah attilah requested a review from edwardfoyle January 16, 2021 01:23
@attilah attilah requested a review from a team as a code owner January 16, 2021 01:23
@lgtm-com
Copy link

lgtm-com bot commented Jan 16, 2021

This pull request introduces 1 alert when merging 0d4ee86 into 3da53b7 - view on LGTM.com

new alerts:

  • 1 for Unused variable, import, function or class

@codecov
Copy link

codecov bot commented Jan 16, 2021

Codecov Report

Merging #6403 (a8833a4) into master (5789b26) will decrease coverage by 0.00%.
The diff coverage is 71.42%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #6403      +/-   ##
==========================================
- Coverage   57.34%   57.34%   -0.01%     
==========================================
  Files         474      474              
  Lines       21671    21670       -1     
  Branches     4307     4307              
==========================================
- Hits        12427    12426       -1     
  Misses       8363     8363              
  Partials      881      881              
Impacted Files Coverage Δ
packages/amplify-cli-core/src/index.ts 94.73% <ø> (ø)
...tion-transformer/src/ModelConnectionTransformer.ts 89.49% <50.00%> (-0.04%) ⬇️
...wscloudformation/utils/trigger-flow-auth-helper.js 77.77% <75.00%> (-0.61%) ⬇️
...es/graphql-connection-transformer/src/resources.ts 78.48% <100.00%> (+0.27%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5e4648c...a8833a4. Read the comment docs.

@lgtm-com
Copy link

lgtm-com bot commented Jan 25, 2021

This pull request introduces 1 alert when merging a8833a4 into 5e4648c - view on LGTM.com

new alerts:

  • 1 for Unused variable, import, function or class

@attilah attilah merged commit 75f5ace into aws-amplify:master Jan 26, 2021
@github-actions
Copy link

This pull request has been automatically locked since there hasn't been any recent activity after it was closed. Please open a new issue for related bugs.

Looking for a help forum? We recommend joining the Amplify Community Discord server *-help channels for those types of questions.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 26, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

amplify auth update break the config file of "Email Verification Link with Redirect" option
2 participants