-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: handle parent relationship without belongsTo for GraphQL #1055
Conversation
6bdcc45
to
7e955e9
Compare
Codecov Report
❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more. @@ Coverage Diff @@
## main #1055 +/- ##
==========================================
+ Coverage 93.84% 93.86% +0.02%
==========================================
Files 124 124
Lines 5797 5819 +22
Branches 1752 1764 +12
==========================================
+ Hits 5440 5462 +22
Misses 339 339
Partials 18 18
Continue to review full report in Codecov by Sentry.
|
def421c
to
dbec349
Compare
dbec349
to
37ea268
Compare
c3e94aa
to
807e8b6
Compare
Problem
The link from a child to a parent is always implemented with an id field on the child holding the id of its parent, customers can optionally annotate this field with
@belongsTo
to make the relationship bidirectional. For forms, we always want to behave as if the relationship is bidirectional, mainly to give us the ability to utilize the autocomplete control to update the parent id.Solution
Add conditional logic for GraphQL to add bidirectional abilities for forms.
Additional Notes
Also adds a step to our Github actions to upload Cypress videos if Cypress tests fail in order to gather more insight when debugging failing tests.
Links
Ticket
GitHub issue:
Other links
Verification
Manual tests
Automated tests
Housekeeping
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.