Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update variables to match local state #1062

Merged
merged 2 commits into from
Aug 4, 2023
Merged

Conversation

rtpascual
Copy link
Contributor

@rtpascual rtpascual commented Aug 4, 2023

Problem

There are inconsistencies in casing and using model name instead of field name for a couple variables used for the Autocomplete control. This causes errors such as: _____ is not defined.

Solution

Update variables used in options and onSelect to match the appropriate local state.

Additional Notes

Update dog-owner-required schema to represent lowercase model fields to ensure we match casing from schema.

Links

Ticket

GitHub issue:

Other links

Verification

Manual tests

Automated tests

  • Unit tests added/updated
  • E2E tests added/updated
  • N/A - (provide a reason)
  • deferred - (provide GitHub issue for tracking)

Housekeeping

  • No non-essential console logs
  • All new files contain license notice

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@codecov-commenter
Copy link

Codecov Report

Merging #1062 (d2778b9) into main (5b553e9) will increase coverage by 0.00%.
The diff coverage is 100.00%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1062   +/-   ##
=======================================
  Coverage   93.86%   93.87%           
=======================================
  Files         124      124           
  Lines        5819     5826    +7     
  Branches     1764     1768    +4     
=======================================
+ Hits         5462     5469    +7     
  Misses        339      339           
  Partials       18       18           
Files Changed Coverage Δ
...-react/lib/forms/form-renderer-helper/all-props.ts 100.00% <ø> (ø)
.../forms/form-renderer-helper/event-handler-props.ts 99.16% <100.00%> (+<0.01%) ⬆️
...act/lib/forms/form-renderer-helper/model-values.ts 92.44% <100.00%> (+0.13%) ⬆️
packages/codegen-ui-react/lib/helpers/index.ts 96.72% <100.00%> (+0.16%) ⬆️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5b553e9...d2778b9. Read the comment docs.

@rtpascual rtpascual marked this pull request as ready for review August 4, 2023 01:28
@rtpascual rtpascual requested a review from a team as a code owner August 4, 2023 01:28
awinberg-aws
awinberg-aws previously approved these changes Aug 4, 2023
Copy link
Contributor

@letsbelopez letsbelopez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@rtpascual rtpascual merged commit f016f36 into main Aug 4, 2023
@rtpascual rtpascual deleted the update-variables branch August 4, 2023 23:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants