Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update inputs for linking and unlinking bidirectional relationships #1085

Merged
merged 1 commit into from
Aug 19, 2023

Conversation

rtpascual
Copy link
Contributor

Problem

When submitting update forms with bidirectional relationships, the form throws with an error message: The variables input contains a field that is not defined for input object type ______.

Solution

Change inputs for update GraphQL calls for linking and unlinking records.

Additional Notes

Links

Ticket

GitHub issue:

Other links

Verification

Manual tests

Automated tests

  • Unit tests added/updated
  • E2E tests added/updated
  • N/A - (provide a reason)
  • deferred - (provide GitHub issue for tracking)

Housekeeping

  • No non-essential console logs
  • All new files contain license notice

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@rtpascual rtpascual marked this pull request as ready for review August 19, 2023 00:03
@rtpascual rtpascual requested a review from a team as a code owner August 19, 2023 00:03
@codecov-commenter
Copy link

Codecov Report

Merging #1085 (c52c565) into main (99ea1ae) will increase coverage by 0.00%.
The diff coverage is 100.00%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1085   +/-   ##
=======================================
  Coverage   93.91%   93.91%           
=======================================
  Files         124      124           
  Lines        5864     5867    +3     
  Branches     1786     1786           
=======================================
+ Hits         5507     5510    +3     
  Misses        339      339           
  Partials       18       18           
Files Changed Coverage Δ
...-react/lib/forms/form-renderer-helper/cta-props.ts 100.00% <ø> (ø)
...form-renderer-helper/bidirectional-relationship.ts 96.38% <100.00%> (+0.13%) ⬆️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 99ea1ae...c52c565. Read the comment docs.

Copy link
Contributor

@letsbelopez letsbelopez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@rtpascual rtpascual merged commit f62567e into main Aug 19, 2023
@rtpascual rtpascual deleted the update-bidirection branch August 19, 2023 01:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants