Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: added more amplify js v6 unit tests fixed a bug #1102

Merged
merged 1 commit into from
Oct 3, 2023

Conversation

letsbelopez
Copy link
Contributor

Problem

We needed more unit test coverage of amplify js v6 api updates.

Solution

Added custom primary key and many to many model tests. It found one bug and the fix is part of the commit to get the tests passing.

Additional Notes

Links

Ticket

GitHub issue:

Other links

Verification

Manual tests

Automated tests

  • Unit tests added/updated
  • E2E tests added/updated
  • N/A - (provide a reason)
  • deferred - (provide GitHub issue for tracking)

Housekeeping

  • No non-essential console logs
  • All new files contain license notice

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@letsbelopez letsbelopez requested a review from a team as a code owner October 2, 2023 23:45
@codecov-commenter
Copy link

Codecov Report

Merging #1102 (067d6d0) into main (acae93c) will not change coverage.
The diff coverage is n/a.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1102   +/-   ##
=======================================
  Coverage   94.00%   94.00%           
=======================================
  Files         125      125           
  Lines        5957     5957           
  Branches     1822     1822           
=======================================
  Hits         5600     5600           
  Misses        339      339           
  Partials       18       18           
Files Coverage Δ
...act/lib/forms/form-renderer-helper/relationship.ts 93.15% <ø> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update acae93c...067d6d0. Read the comment docs.

@letsbelopez letsbelopez merged commit 6cce085 into main Oct 3, 2023
5 checks passed
@letsbelopez letsbelopez deleted the add-tests-amplifyjs-v6 branch October 3, 2023 16:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants