Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: refactor override and utils to strings #1106

Merged
merged 1 commit into from
Oct 16, 2023
Merged

Conversation

Jshhhh
Copy link
Contributor

@Jshhhh Jshhhh commented Oct 13, 2023

Problem

refactor override and utils functions to strings

Automated tests

  • Unit tests added/updated
  • E2E tests added/updated
  • N/A - (provide a reason)
  • deferred - (provide GitHub issue for tracking)

Housekeeping

  • No non-essential console logs
  • All new files contain license notice

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@Jshhhh Jshhhh requested a review from a team as a code owner October 13, 2023 00:10
@Jshhhh Jshhhh force-pushed the refactor-overrides branch from c997674 to ea8cbd9 Compare October 13, 2023 06:38
@codecov-commenter
Copy link

codecov-commenter commented Oct 13, 2023

Codecov Report

Merging #1106 (b5d1651) into main (4fb3cb7) will decrease coverage by 0.28%.
The diff coverage is 37.43%.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1106      +/-   ##
==========================================
- Coverage   91.36%   91.09%   -0.28%     
==========================================
  Files         141      143       +2     
  Lines        6244     6288      +44     
  Branches     1841     1897      +56     
==========================================
+ Hits         5705     5728      +23     
- Misses        517      540      +23     
+ Partials       22       20       -2     
Files Coverage Δ
.../codegen-ui-react/lib/forms/react-form-renderer.ts 96.78% <100.00%> (+0.01%) ⬆️
...ges/codegen-ui-react/lib/imports/import-mapping.ts 100.00% <ø> (ø)
...gen-ui-react/lib/react-studio-template-renderer.ts 93.62% <100.00%> (+0.01%) ⬆️
...-react/lib/react-utils-studio-template-renderer.ts 95.00% <100.00%> (-1.00%) ⬇️
...codegen-ui-react/lib/utils-file-functions/index.ts 100.00% <100.00%> (ø)
...le-functions/overrides/getOverridesFromVariants.ts 100.00% <100.00%> (ø)
...-react/lib/utils-file-functions/overrides/index.ts 100.00% <100.00%> (ø)
...e-functions/overrides/mergeVariantsAndOverrides.ts 100.00% <100.00%> (ø)
...b/utils-file-functions/overrides/override-types.ts 100.00% <100.00%> (ø)
...react/lib/utils-file-functions/string-formatter.ts 100.00% <100.00%> (ø)
... and 7 more

... and 7 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4fb3cb7...b5d1651. Read the comment docs.

@Jshhhh Jshhhh force-pushed the refactor-overrides branch from ea8cbd9 to b5d1651 Compare October 13, 2023 19:34
@Jshhhh Jshhhh merged commit 1e2b41a into main Oct 16, 2023
5 checks passed
@Jshhhh Jshhhh deleted the refactor-overrides branch October 16, 2023 20:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants