Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: join table related model name using incorrect casing #1124

Merged
merged 1 commit into from
Oct 23, 2023

Conversation

letsbelopez
Copy link
Contributor

Problem

For graphql many many relationships, the onSubmit function has a reduce function to update the related model. This callback function was making a reference to the actual model instead of the reduce callback's parameter. One was lower case and the other was title cased.

Solution

Use the same value that's being used to create the callbacks arguments.

Additional Notes

No.

Links

Ticket

GitHub issue:

Other links

Verification

Manual tests

Automated tests

  • Unit tests added/updated
  • E2E tests added/updated
  • N/A - (provide a reason)
  • deferred - (provide GitHub issue for tracking)

Housekeeping

  • No non-essential console logs
  • All new files contain license notice

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@letsbelopez letsbelopez requested a review from a team as a code owner October 23, 2023 20:02
@codecov-commenter
Copy link

Codecov Report

Merging #1124 (fb1b561) into main (b59764c) will not change coverage.
The diff coverage is n/a.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1124   +/-   ##
=======================================
  Coverage   93.74%   93.74%           
=======================================
  Files         151      151           
  Lines        6269     6269           
  Branches     1858     1858           
=======================================
  Hits         5877     5877           
  Misses        373      373           
  Partials       19       19           
Files Coverage Δ
...act/lib/forms/form-renderer-helper/relationship.ts 93.15% <ø> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b59764c...fb1b561. Read the comment docs.

@letsbelopez letsbelopez merged commit b047400 into main Oct 23, 2023
5 checks passed
@letsbelopez letsbelopez deleted the bug-joinTableRelatedModelName branch October 23, 2023 22:34
letsbelopez added a commit that referenced this pull request Oct 25, 2023
…allback (#1124)

Co-authored-by: David Lopez <lopezbnd@amazon.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants